Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #5672: fixed the tree indentation issue caused by the expansion icon #5677

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Fixed #5672: fixed the tree indentation issue caused by the expansion icon #5677

merged 1 commit into from
Jul 10, 2019

Conversation

fangnx
Copy link

@fangnx fangnx commented Jul 9, 2019 •
edited
Loading

  • Fixed the indentation alignment issue in tree by adjusting the padding of the expansion toggle icon.

Before:

See #5672.

With this patch:

image
image

Fixed eclipse-theia#5672: fixed the tree indentation issue caused by …
2518150 
…the expansion toggle icon

- Fixed the indentation alignment issue in tree by adjusting the padding of the expansion toggle icon.

Signed-off-by: fangnx <[email protected]>
vince-fugnitto
vince-fugnitto approved these changes Jul 9, 2019
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me :)

@akosyakov akosyakov added the navigator issues related to the navigator/explorer label Jul 10, 2019
@akosyakov
Copy link
Member

@vince-fugnitto please be more specific. What did you test? It is very generic functionality, we should look at all possible trees to make sure that they look good it. If you did it please merge.

@akosyakov akosyakov added tree issues related to the tree (ex: tree widget) and removed navigator issues related to the navigator/explorer labels Jul 10, 2019
@akosyakov akosyakov requested a review from jbicker July 10, 2019 08:18
@akosyakov akosyakov added the ui/ux issues related to user interface / user experience label Jul 10, 2019
jbicker
jbicker approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have looked into the other trees and did not see any ui glitches.

@jbicker jbicker merged commit 6f63f5c into eclipse-theia:master Jul 10, 2019
@vince-fugnitto
Copy link
Member

@vince-fugnitto please be more specific. What did you test? It is very generic functionality, we should look at all possible trees to make sure that they look good it. If you did it please merge.

Sorry, I looked in general to trees that have collapsable nodes and nodes with icons, the explorer, outline, problems. I'll be more specific next time in the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

@jbicker jbicker jbicker approved these changes

Assignees
No one assigned
Labels
tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fangnx @akosyakov @vince-fugnitto @jbicker